[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: es 0.7
> 2. It still looks like the dup redirection needs to call cpfd() instead
> of mvfd().
oops. i must have ``fixed'' this twice, the second one changing it back to the
old (wrong) way. line 93 of prim-io.c should be a cpfd not a mvfd.
> 1. Don't know what exactly 0.7 is doing with this protecting file
> descriptors business, but I suspect there's effectively no change.
that's not true, but there is a bug in that code. line 428 of input.c which is
i->fd = close(i->fd);
should (of course) be
i->fd = dup(i->fd);
because the 0 that close() returns is not too useful.
next time i'll try to be more careful.